Add execution report heartbeat alerts - #130
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d17d6ba16
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| accepted = [] | ||
| accepted_by_service: dict[str, tuple[str, dt.datetime, str]] = {} | ||
| inspected = [] | ||
| for uri, updated in sorted_objects[:max_reports]: |
There was a problem hiding this comment.
When CLOUD_RUN_SERVICE_TARGETS_JSON/RUNTIME_HEARTBEAT_REQUIRED_SERVICES points at a shared report bucket, this loop only reads the newest 20 objects globally before applying _payload_matches. If more than 20 newer reports from other services exist in the lookback window, an acceptable report for a required service that is still within the window is never inspected and the workflow alerts/fails as “missing acceptable report” even though the service reported successfully. Keep scanning until all required services are found or apply the limit after service filtering.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation